linux-kernel - Re: [PATCH] regulator: kconfig: make max8973 driver to depend on GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150408164323.GA6023@sirena.org.uk>
Date:	Wed, 8 Apr 2015 17:43:23 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	lgirdwood@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: kconfig: make max8973 driver to depend on
 GPIOLIB

On Wed, Apr 08, 2015 at 07:07:07PM +0530, Laxman Dewangan wrote:
> MAX8973 regulator driver uses the GPIO APIs for accessing the
> control signal connected to its pin from host processor.
> 
> Make this driver depends on GPIOLIB.

The GPIO usage in the driver appears to be optional, it handles the GPIO
not being controllable.  This suggests to me that the gpiolib dependency
shouldn't be required and that it would be better to fix this by
ensuring that all the gpiolib functions being used have appropriate
stubs.  Which ones are causing problems?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)