linux-kernel - Re: [PATCH] regulator: kconfig: make max8973 driver to depend on GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 9 Apr 2015 15:31:09 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nel.org>
CC:	<lgirdwood@...il.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: kconfig: make max8973 driver to depend on
 GPIOLIB

On Wednesday 08 April 2015 10:13 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Wed, Apr 08, 2015 at 07:07:07PM +0530, Laxman Dewangan wrote:
>> MAX8973 regulator driver uses the GPIO APIs for accessing the
>> control signal connected to its pin from host processor.
>>
>> Make this driver depends on GPIOLIB.
> The GPIO usage in the driver appears to be optional, it handles the GPIO
> not being controllable.  This suggests to me that the gpiolib dependency
> shouldn't be required and that it would be better to fix this by
> ensuring that all the gpiolib functions being used have appropriate
> stubs.  Which ones are causing problems?
>

Thanks for review.

Sometime ago, I got the comiplation error on random config for one of 
architecture which was not having GPIO architecture. The compilation 
error was reported on tps62360-regulator.c which is also using similar 
i2c calls.

So to avoid similar issue, I make this depends on GPIOLIB.

However, I looked gpio.h and it has all required APIs as static inline 
if GPIOLIB is not there so atleast compilation issue will not be there.

Now going through code, I think if gpios are not there then also it 
should work.
Not tested this on my board as I can not boot without gpio.

I think we can drop this patch.

Thanks,
Laxman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/