linux-kernel - Re: [PATCH v4] x86, selftests: Add sigreturn selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALCETrW+UfcXnxHq_8mHGQBGKY_86XeT1PhErVVRZcTtF655SA@mail.gmail.com>
Date:	Tue, 7 Apr 2015 21:39:54 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Michael Ellerman <mpe@...erman.id.au>
Cc:	Andy Lutomirski <luto@...nel.org>, Ingo Molnar <mingo@...nel.org>,
	X86 ML <x86@...nel.org>, Shuah Khan <shuah.kh@...sung.com>,
	Borislav Petkov <bp@...en8.de>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] x86, selftests: Add sigreturn selftest

On Tue, Apr 7, 2015 at 8:42 PM, Michael Ellerman <mpe@...erman.id.au> wrote:
> On Mon, 2015-04-06 at 23:11 -0700, Andy Lutomirski wrote:
>> On Mon, Apr 6, 2015 at 8:39 PM, Michael Ellerman <mpe@...erman.id.au> wrote:
>> > On Mon, 2015-04-06 at 19:01 -0700, Andy Lutomirski wrote:
>> >> This is my sigreturn test, added mostly unchanged from its old home.
>> >> It exercises the sigreturn(2) syscall, specifically focusing on its
>> >> interactions with various IRET corner cases.  It tests for correct
>> >> behavior in several areas that were historically dangerously buggy.
>> >> For example, it exercises espfix on kernels of both bitnesses under
>> >> various conditions, and it contains exploits for several now-fixed
>> >> bugs in IRET error handling.
>> >>
>> >> If you run it on older kernels, your system will crash.  It probably
>> >> won't eat your data in the process.
>> >>
>> >> There is no released kernel on which the sigreturn_64 test will
>> >> pass, but it passes on tip:x86/asm.
>> >>
>> >> IMO it's unfortunate that I need to provide a special script to run
>> >> tests.  I'd rather just list my targets.
>> >
>> > If you use lib.mk you can.
>> >
>> >   https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git/log/?h=next
>> >
>> > See for example:
>> >
>> >   https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=next&id=5744de542dd4b963c2975e6f70844ce2899864e4
>>
>> Will do for 4.2.  In the mean time, there's no base on which lib.mk
>> exists and the test works.
>
> OK.
>
> Shua seems to have already sent a pull request for 4.1, which is rather early
> to say the least, but suggests you've missed 4.1 anyway - unless you want it to
> go via some other tree.

The plan is to go in via tip:x86/asm, I think.  That's where the fix
that the test depends on lives.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/