linux-kernel - [PATCH] irq: Remove unnecessary warning with affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5524B2C4.50009@jp.fujitsu.com>
Date:	Wed, 8 Apr 2015 13:47:00 +0900
From:	Seiichi Ikarashi <s.ikarashi@...fujitsu.com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Ingo Molnar <mingo@...nel.org>
CC:	<linux-kernel@...r.kernel.org>
Subject: [PATCH] irq: Remove unnecessary warning with affinity_hint

Hi,

If you turn off a PCI device whose driver has set affinity_hint,
you will get warning message which does _not_ explain the reason
why it appeared from the user's point of view.

  # echo 0 > /sys/bus/pci/slots/65/power

  Apr 28 20:29:39 localhost kernel: ------------[ cut here ]------------
  Apr 28 20:29:39 localhost kernel: WARNING: at kernel/irq/manage.c:1002 __free_irq+0x22d/0x250() (Tainted: P           ---------------   )
  (snip)

Users will misunderstand some problem has happened
even though he or she succeeded to turn off the device.
I suppose this warning was originally for a debug purpose
for driver developers and has incidentally been left.

Just remove the warning is good and enough.

Signed-off-by: Seiichi Ikarashi <s.ikarashi@...fujitsu.com>

--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1335,7 +1335,7 @@ static struct irqaction *__free_irq(unsi
 
 #ifdef CONFIG_SMP
 	/* make sure affinity_hint is cleaned up */
-	if (WARN_ON_ONCE(desc->affinity_hint))
+	if (desc->affinity_hint)
 		desc->affinity_hint = NULL;
 #endif
 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/