linux-kernel - Re: [PATCH] x86, iommu: Fix header comments regarding standard and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Apr 2015 09:37:44 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>
Cc:	mingo@...hat.com, bp@...e.de, tglx@...utronix.de, hpa@...or.com,
	x86@...nel.org, linux-kernel@...r.kernel.org,
	konrad.wilk@...cle.com
Subject: Re: [PATCH] x86, iommu: Fix header comments regarding standard and
 _FINISH macros


* Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com> wrote:

> The comment line regarding IOMMU_INIT and IOMMU_INIT_FINISH macros
> is incorrect:
> "The standard vs the _FINISH differs in that the _FINISH variant will
>  continue detecting other IOMMUs in the call list..."
> It should be "..the *standard* variant will continue detecting..."
> 
> Fix that.
> 
> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>
> ---
>  arch/x86/include/asm/iommu_table.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
> index f42a047..16845d4 100644
> --- a/arch/x86/include/asm/iommu_table.h
> +++ b/arch/x86/include/asm/iommu_table.h
> @@ -79,7 +79,7 @@ struct iommu_table_entry {
>   *  d). Similar to the 'init', except that this gets called from pci_iommu_init
>   *      where we do have a memory allocator.
>   *
> - * The standard vs the _FINISH differs in that the _FINISH variant will
> + * The standard vs the _FINISH differs in that the standard variant will
>   * continue detecting other IOMMUs in the call list after the
>   * the detection routine returns a positive number. The _FINISH will
>   * stop the execution chain. Both will still call the 'init' and

So while we are touching it, how about making it more readable:

    *
    * The standard vs the _FINISH variants differ in that the
    * standard variant will continue detecting other IOMMUs in the 
    * call list after the detection routine returns a positive number. 
    * The _FINISH variant will stop the execution chain. Both variants 
    * will still call the 'init' and ...
    *

I also fixed a 'the the' typo.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/