linux-kernel - Re: [PATCH 2/2] x86/earlyprintk: setup earlyprintk as early as possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANCZXo5sBjrTONf2Lt+g1sqcO5GopLhm82HWg0pB0EnDUi2ghw@mail.gmail.com>
Date:	Thu, 9 Apr 2015 13:39:13 +0600
From:	Alexander Kuleshov <kuleshovmail@...il.com>
To:	Peter Hurley <peter@...leysoftware.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Yinghai Lu <yinghai@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] x86/earlyprintk: setup earlyprintk as early as possible

Hello Peter,

2015-04-08 17:32 GMT+06:00 Peter Hurley <peter@...leysoftware.com>:
>> +
>> +void setup_early_serial_console() {
>
> If you put this function in kernel/early_printk.c, then
> setup_early_printk() can remain file scope.
>

Yes, right. will fix it.

>
> The WARN is still required here because the register_console() caller
> is not always obvious.
>
> A better way to achieve what you want is to not re-register the console
> to begin with. Looking at early_console_register() and setup_early_printk(),
> it seems like re-registration would already be prevented (since early_console
> != 0 after the first call to early_console_register())?  Have you tried this?
>

hmm, now, thanks for the point will test it.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/