linux-kernel - Re: [PATCH 1/2] perf data: Show error message when ctf setup failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55263608.2070301@huawei.com>
Date:	Thu, 9 Apr 2015 16:19:20 +0800
From:	He Kuang <hekuang@...wei.com>
To:	Jiri Olsa <jolsa@...hat.com>
CC:	<bigeasy@...utronix.de>, <jolsa@...nel.org>, <acme@...nel.org>,
	<a.p.zijlstra@...llo.nl>, <mingo@...hat.com>,
	<wangnan0@...wei.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] perf data: Show error message when ctf setup failed

Hi, jirka
On 2015/4/9 1:45, Jiri Olsa wrote:
> On Wed, Apr 08, 2015 at 12:49:19PM +0800, He Kuang wrote:
>> Show message when errors occurred during ctf conversion setup.
>>
>> Before this patch:
>>    $ ./perf data convert --to-ctf=ctf
>>    $ echo $?
>>    255
>>
>> After this patch:
>>    $ ./perf data convert --to-ctf=ctf
>>    Error during CTF convert setup.
> so I have like 5 more patches from the original CTF set
> which I'm holding until all works with tracecompass:
>    http://marc.info/?l=linux-kernel&m=142736197610573&w=2
>
> Is it working for you? How do you test resulted CTF data?
>
> anyway the patch looks ok, just small nit below

I tested by using babeltrace binary and it works.

After receiving your reply, I test on the latest tracecompass. A
folder named 'ctf' is showed instead of the expected file
'ctf-data', this folder only contains the raw metadata and
perf-stream files but not analysed.
>> Signed-off-by: He Kuang <hekuang@...wei.com>
>> ---
>>   tools/perf/util/data-convert-bt.c | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
>> index dd17c9a..a5b89b9 100644
>> --- a/tools/perf/util/data-convert-bt.c
>> +++ b/tools/perf/util/data-convert-bt.c
>> @@ -847,11 +847,15 @@ int bt_convert__perf2ctf(const char *input, const char *path, bool force)
>>   		(double) c.events_size / 1024.0 / 1024.0,
>>   		c.events_count);
>>   
>> -	/* its all good */
>> -free_session:
>>   	perf_session__delete(session);
>> +	ctf_writer__cleanup(cw);
>> +
> this leg can also fail due to:
>
>          err = perf_session__process_events(session);
>          if (!err)
>                  err = bt_ctf_stream_flush(cw->stream);
>
>
> so we might want to inform about that like:
> 	if (err)
> 		pr_err("Error during conversion.\n");
>
>
> thanks,
> jirka
>
>> +	return err;
>>   
>> +free_session:
>> +	perf_session__delete(session);
>>   free_writer:
>>   	ctf_writer__cleanup(cw);
>> +	pr_err("Error during CTF convert setup.\n");
>>   	return err;
>>   }
>> -- 
>> 2.3.3.220.g9ab698f
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/