linux-kernel - Re: [PATCHv2 1/2] perf data: Show error message when conversion failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150409094521.GA3341@krava.brq.redhat.com>
Date:	Thu, 9 Apr 2015 11:45:21 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	He Kuang <hekuang@...wei.com>
Cc:	bigeasy@...utronix.de, jolsa@...nel.org, acme@...nel.org,
	a.p.zijlstra@...llo.nl, mingo@...hat.com, wangnan0@...wei.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 1/2] perf data: Show error message when conversion
 failed

On Thu, Apr 09, 2015 at 03:56:00PM +0800, He Kuang wrote:
> Show message when errors occurred during conversion setup and conversion
> process.
> 
> Before this patch:
>   $ ./perf data convert --to-ctf=ctf
>   $ echo $?
>   255
> 
> After this patch:
>   $ ./perf data convert --to-ctf=ctf
>   Error during conversion setup.
> 
> Signed-off-by: He Kuang <hekuang@...wei.com>

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka

> ---
>  tools/perf/util/data-convert-bt.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
> index 7a12047..de80ded 100644
> --- a/tools/perf/util/data-convert-bt.c
> +++ b/tools/perf/util/data-convert-bt.c
> @@ -896,6 +896,8 @@ int bt_convert__perf2ctf(const char *input, const char *path, bool force)
>  	err = perf_session__process_events(session);
>  	if (!err)
>  		err = bt_ctf_stream_flush(cw->stream);
> +	else
> +		pr_err("Error during conversion.\n");
>  
>  	fprintf(stderr,
>  		"[ perf data convert: Converted '%s' into CTF data '%s' ]\n",
> @@ -906,11 +908,15 @@ int bt_convert__perf2ctf(const char *input, const char *path, bool force)
>  		(double) c.events_size / 1024.0 / 1024.0,
>  		c.events_count);
>  
> -	/* its all good */
> -free_session:
>  	perf_session__delete(session);
> +	ctf_writer__cleanup(cw);
>  
> +	return err;
> +
> +free_session:
> +	perf_session__delete(session);
>  free_writer:
>  	ctf_writer__cleanup(cw);
> +	pr_err("Error during conversion setup.\n");
>  	return err;
>  }
> -- 
> 2.3.3.220.g9ab698f
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/