linux-kernel - RE: [PATCH V1 2/2] devicetree: Add bindings for DA9063 OnKey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Apr 2015 10:31:34 +0000
From:	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	DT <devicetree@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	INPUT <linux-input@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Samuel Ortiz" <sameo@...ux.intel.com>
Subject: RE: [PATCH V1 2/2] devicetree: Add bindings for DA9063 OnKey

On 09 April 2015 10:22 Lee Jones wrote

> > From: Steve Twiss <stwiss.opensource@...semi.com>
> What format is this?  Why aren't you using `git send-email`?

I am using a git format-patch to generate the patches but our in-house IT
department complications disallow the use of git send-email.

> > This patch is dependent on PATCH V1 1/2
> How can there be dependencies between a binding document and a driver
> patch?

I'll remove those circular dependencies for the next patch

> > +- onkey : This node defines the OnKey settings for controlling the key
> > +  functionality of the device. The node should contain the compatible
> keyword
> 
> s/keyword/property/

... will do that search and replace

> > +  DA9063_REG_CONFIG_I and the device tree entry "dlg,disable-key-
> power" can
> 
> I feel like you're burying the dlg,disable-key-power documentation in
> side a long winded paragraph.  It's better to start the line with it,
> like:
> 
> Optional Properties:
> 
> dlg,disable-key-power:  Disable power-down using a long key-press.  If
> 			absent <blah> ...
> 

okay, I'll make that change.

Thanks for the comments,
I'll send PATCH V2 after I make the changes requested by yourself and Paul Bolle
(see https://lkml.org/lkml/2015/4/9/150).

Regards,
Steve