linux-kernel - Re: [PATCH v6 3/3] leds: Add ktd2692 flash LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Apr 2015 12:16:39 +0300
From:	Sakari Ailus <sakari.ailus@....fi>
To:	Ingi Kim <ingi2.kim@...sung.com>
Cc:	cooloney@...il.com, rpurdie@...ys.net, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	j.anaszewski@...sung.com, varkabhadram@...il.com, joe@...ches.com,
	sw0312.kim@...sung.com, cw00.choi@...sung.com,
	jh80.chung@...sung.com, ideal.song@...sung.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org
Subject: Re: [PATCH v6 3/3] leds: Add ktd2692 flash LED driver

Hi Ingi,

On Fri, Apr 10, 2015 at 05:45:30PM +0900, Ingi Kim wrote:
...
> >> +	ret = devm_gpio_request_one(dev, led->ctrl_gpio,
> >> +					GPIOF_OPEN_SOURCE, "ctrl-gpio");
> >
> > I think you could simply use devm_gpio_get(), and start using the new API
> > instead. It'd save quite a few lines of code, too.
> >
> 
> did you mean devm_gpiod_get()
> Ok, I'll check it

Yes, that's what I meant.

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@....fi	XMPP: sailus@...iisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/