linux-kernel - Re: [PATCH] drivers/usb/core: devio.c: Removed various errors and warnings generated by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Apr 2015 10:20:38 -0700
From:	Joe Perches <joe@...ches.com>
To:	Chase Metzger <chasemetzger15@...il.com>
Cc:	gregkh@...uxfoundation.org, stern@...land.harvard.edu,
	hdegoede@...hat.com, oneukum@...e.de, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/usb/core: devio.c: Removed various errors and
 warnings generated by checkpatch.pl

On Sat, 2015-04-11 at 00:53 -0700, Chase Metzger wrote:
> Fixed several errors and warnings.
[]
> Lines 1040 and 1591: changed dev_printk(KERN_DEBUG, ...) to dev_dbg(...).

These changes hav the possibly undesired effect of
removing these messages completely when DEBUG is not
#defined or when CONFIG_DYNAMIC_DEBUG is not enabled
and these messages are not specifically enabled.

> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
[]
> @@ -1040,7 +1040,7 @@ static int proc_control(struct usb_dev_state *ps, void __user *arg)
>  		snoop_urb(dev, NULL, pipe, max(i, 0), min(i, 0), COMPLETE, NULL, 0);
>  	}
>  	if (i < 0 && i != -EPIPE) {
> -		dev_printk(KERN_DEBUG, &dev->dev, "usbfs: USBDEVFS_CONTROL "
> +		dev_dbg(&dev->dev, "usbfs: USBDEVFS_CONTROL "
>  			   "failed cmd %s rqt %u rq %u len %u ret %d\n",
>  			   current->comm, ctrl.bRequestType, ctrl.bRequest,
>  			   ctrl.wLength, i);
[]
> @@ -1591,8 +1591,7 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb
>  	}
>  
>  	if (ret) {
> -		dev_printk(KERN_DEBUG, &ps->dev->dev,
> -			   "usbfs: usb_submit_urb returned %d\n", ret);
> +		dev_dbg(&ps->dev->dev, "usbfs: usb_submit_urb returned %d\n", ret);
>  		snoop_urb(ps->dev, as->userurb, as->urb->pipe,
>  				0, ret, COMPLETE, NULL, 0);
>  		async_removepending(as);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/