linux-kernel - Re: [PATCH] drivers/usb/core: devio.c: Removed various errors and warnings generated by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Apr 2015 10:52:03 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	Chase Metzger <chasemetzger15@...il.com>,
	gregkh@...uxfoundation.org
CC:	stern@...land.harvard.edu, oneukum@...e.de,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/usb/core: devio.c: Removed various errors and
 warnings generated by checkpatch.pl

Hi,

On 04/11/2015 09:53 AM, Chase Metzger wrote:
> Fixed several errors and warnings.
>
> Lines 29, 103, 1319, 1906 and 2408: removed unnecessary spaces or added appropriate spaces.
> Lines 1040 and 1591: changed dev_printk(KERN_DEBUG, ...) to dev_dbg(...).
>
> Signed-off-by: Chase Metzger <chasemetzger15@...il.com>

Looks good to me:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans

> ---
>   drivers/usb/core/devio.c | 15 +++++++--------
>   1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index 1163553..62c0be6 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -29,7 +29,7 @@
>    *    22.12.1999   0.1   Initial release (split from proc_usb.c)
>    *    04.01.2000   0.2   Turned into its own filesystem
>    *    30.09.2005   0.3   Fix user-triggerable oops in async URB delivery
> - *    			 (CAN-2005-3055)
> + *			 (CAN-2005-3055)
>    */
>
>   /*****************************************************************************/
> @@ -103,7 +103,7 @@ MODULE_PARM_DESC(usbfs_snoop, "true to log all usbfs traffic");
>   #define snoop(dev, format, arg...)				\
>   	do {							\
>   		if (usbfs_snoop)				\
> -			dev_info(dev , format , ## arg);	\
> +			dev_info(dev, format, ## arg);		\
>   	} while (0)
>
>   enum snoop_when {
> @@ -1040,7 +1040,7 @@ static int proc_control(struct usb_dev_state *ps, void __user *arg)
>   		snoop_urb(dev, NULL, pipe, max(i, 0), min(i, 0), COMPLETE, NULL, 0);
>   	}
>   	if (i < 0 && i != -EPIPE) {
> -		dev_printk(KERN_DEBUG, &dev->dev, "usbfs: USBDEVFS_CONTROL "
> +		dev_dbg(&dev->dev, "usbfs: USBDEVFS_CONTROL "
>   			   "failed cmd %s rqt %u rq %u len %u ret %d\n",
>   			   current->comm, ctrl.bRequestType, ctrl.bRequest,
>   			   ctrl.wLength, i);
> @@ -1319,7 +1319,7 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb
>   	is_in = (uurb->endpoint & USB_ENDPOINT_DIR_MASK) != 0;
>
>   	u = 0;
> -	switch(uurb->type) {
> +	switch (uurb->type) {
>   	case USBDEVFS_URB_TYPE_CONTROL:
>   		if (!usb_endpoint_xfer_control(&ep->desc))
>   			return -EINVAL;
> @@ -1591,8 +1591,7 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb
>   	}
>
>   	if (ret) {
> -		dev_printk(KERN_DEBUG, &ps->dev->dev,
> -			   "usbfs: usb_submit_urb returned %d\n", ret);
> +		dev_dbg(&ps->dev->dev, "usbfs: usb_submit_urb returned %d\n", ret);
>   		snoop_urb(ps->dev, as->userurb, as->urb->pipe,
>   				0, ret, COMPLETE, NULL, 0);
>   		async_removepending(as);
> @@ -1906,7 +1905,7 @@ static int proc_releaseinterface(struct usb_dev_state *ps, void __user *arg)
>   		return -EFAULT;
>   	if ((ret = releaseintf(ps, ifnum)) < 0)
>   		return ret;
> -	destroy_async_on_interface (ps, ifnum);
> +	destroy_async_on_interface(ps, ifnum);
>   	return 0;
>   }
>
> @@ -2408,7 +2407,7 @@ static int usbdev_notify(struct notifier_block *self,
>   }
>
>   static struct notifier_block usbdev_nb = {
> -	.notifier_call = 	usbdev_notify,
> +	.notifier_call =	usbdev_notify,
>   };
>
>   static struct cdev usb_device_cdev;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/