linux-kernel - Re: [PATCH] serial: of-serial: Remove device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Apr 2015 11:50:16 -0400
From:	Peter Hurley <peter@...leysoftware.com>
To:	Michal Simek <michal.simek@...inx.com>,
	linux-kernel@...r.kernel.org, monstr@...str.eu
CC:	Arnd Bergmann <arnd@...db.de>, stable@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-serial@...r.kernel.org, Jiri Slaby <jslaby@...e.cz>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] serial: of-serial: Remove device_type = "serial" registration

[ + Arnd ]

Hi Michal,

On 04/13/2015 10:35 AM, Michal Simek wrote:
> Do not probe all serial drivers by of_serial.c which are using
> device_type = "serial"; property. Only drivers which have valid
> compatible strings listed in the driver should be probed.

What does this fix?
Is there some kind of probe problem you're trying to address?
Are you trying to silence the error message?

> When PORT_UNKNOWN probe will fail anyway.

Ok, but doesn't device_attach() just continue to try to match other
drivers on the platform bus?

Regards,
Peter Hurley

> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> CC: <stable@...r.kernel.org>
> ---
> 
>  drivers/tty/serial/of_serial.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
> index 33fb94f78967..0a52c8b55a5f 100644
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -344,7 +344,6 @@ static struct of_device_id of_platform_serial_table[] = {
>  	{ .compatible = "ibm,qpace-nwp-serial",
>  		.data = (void *)PORT_NWPSERIAL, },
>  #endif
> -	{ .type = "serial",         .data = (void *)PORT_UNKNOWN, },
>  	{ /* end of list */ },
>  };
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/