| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <552D33B0.6040808@6wind.com> Date: Tue, 14 Apr 2015 17:35:12 +0200 From: Nicolas Dichtel <nicolas.dichtel@...nd.com> To: Patrick McHardy <kaber@...sh.net>, Honggang Li <honli@...hat.com> CC: roland@...nel.org, sean.hefty@...el.com, hal.rosenstock@...il.com, davem@...emloft.net, alex.estrin@...el.com, dledford@...hat.com, edumazet@...gle.com, erezsh@...lanox.com, maheshb@...gle.com, jbenc@...hat.com, ebiederm@...ssion.com, elfring@...rs.sourceforge.net, f.fainelli@...il.com, linux@...ck-us.net, andrew@...n.ch, sfeldma@...il.com, alexander.h.duyck@...el.com, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get_iflink Le 14/04/2015 17:26, Patrick McHardy a écrit : > On 14.04, Honggang Li wrote: [snip] >> - return vlan->lowerdev->ifindex; >> + if (vlan && vlan->lowerdev) >> + return vlan->lowerdev->ifindex; > > That is completely useless. vlan (=netdev_priv) can not be NULL as > netdev_priv() never returns NULL and vlan->lowerdev is always valid > because a macvlan wouldn't make much sense otherwise. > And I suspect that it is the same for ipvlan and dsa. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists