linux-kernel - Re: [PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150414153514.GK7874@acer.localdomain>
Date:	Tue, 14 Apr 2015 16:35:14 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Honggang LI <honli@...hat.com>
Cc:	roland@...nel.org, sean.hefty@...el.com, hal.rosenstock@...il.com,
	davem@...emloft.net, alex.estrin@...el.com, dledford@...hat.com,
	edumazet@...gle.com, erezsh@...lanox.com,
	nicolas.dichtel@...nd.com, maheshb@...gle.com, jbenc@...hat.com,
	ebiederm@...ssion.com, elfring@...rs.sourceforge.net,
	f.fainelli@...il.com, linux@...ck-us.net, andrew@...n.ch,
	sfeldma@...il.com, alexander.h.duyck@...el.com,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH linux-next 3/4] macvlan: fix possible NULL pointer
 dereference in macvlan_dev_get_iflink

On 14.04, Honggang LI wrote:
> On Tue, Apr 14, 2015 at 04:26:27PM +0100, Patrick McHardy wrote:
> > 
> > That is completely useless. vlan (=netdev_priv) can not be NULL as
> > netdev_priv() never returns NULL and vlan->lowerdev is always valid
> > because a macvlan wouldn't make much sense otherwise.
> 
> OK, please drop this patch.

Well, the fact that netdev_priv never return NULL implies all your
patches need to be redone.

And I suggest you check whether this condition can actually happen.
Just because it can in one driver says nothing at all about others.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/