linux-kernel - Re: [patch v2] net: hip04: Make tx coalesce timer actually work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150415.172227.1813336970100255734.davem@davemloft.net>
Date:	Wed, 15 Apr 2015 17:22:27 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tglx@...utronix.de
Cc:	arnd@...db.de, linux-kernel@...r.kernel.org, peterz@...radead.org,
	mingo@...nel.org, dingtianhong@...wei.com, zhangfei.gao@...aro.org,
	dan.carpenter@...cle.com, netdev@...r.kernel.org
Subject: Re: [patch v2] net: hip04: Make tx coalesce timer actually work

From: Thomas Gleixner <tglx@...utronix.de>
Date: Tue, 14 Apr 2015 21:42:42 +0200 (CEST)

> The code sets the expiry value of the timer to a relative value and
> starts it with hrtimer_start_expires. That's fine, but that only works
> once. The timer is started in relative mode, so the expiry value gets
> overwritten with the absolut expiry time (now + expiry).
> 
> So once the timer expired, a new call to hrtimer_start_expires results
> in an immidiately expired timer, because the expiry value is
> already in the past.
> 
> Use the proper mechanisms to (re)start the timer in the intended way.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

Applied, thanks Thomas.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/