linux-kernel - Re: [PATCH v2 13/21] staging: rtl8192e: Fix PREFER_PR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552ED7C3.5080407@gmail.com>
Date:	Wed, 15 Apr 2015 23:27:31 +0200
From:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 13/21] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings

On 14.04.2015 10:07, Dan Carpenter wrote:
> On Mon, Apr 13, 2015 at 11:47:36PM +0200, Mateusz Kulikowski wrote:
>> Fix most of remaining PREFER_PR_LEVEL warnings in rtllib.
>> Replace printk() with pr_* where possible.
(...)
>>  #define RTLLIB_DEBUG_DATA(level, data, datalen)	\
>>  	do {							\
>>  		if ((rtllib_debug_level & (level)) == (level)) {	\
>> -			printk(KERN_DEBUG "rtllib: %s()\n", __func__);	\
>> +			pr_debug("rtllib: %s()\n", __func__);	\
>>  			print_hex_dump_bytes(KERN_DEBUG, DUMP_PREFIX_NONE, \
>>  					     data, datalen); \
>>  		}					\
> 
> We've made it slightly more tricky to turn on these debug statements.
> 
> I don't think that's a big problem.  I don't think anyone cares about
> them.  They are just noise is my guess.

I agree that lot of the debug messages in that driver are garbage;
Proposal for v3:
- throw away all garbage messages (like "==========>__func__\n"),
- use proper print functions (and loglevels) for remaining RTLLIB_ debug messages (possibly reword them)
- throw away RTLLIB_DEBUG and RTLLIB_DEBUG_DATA macros (i.e. whole RTL 'logging' mechanism)

Most of the messages will stay on DEBUG loglevel, so will not bother "normal" users.

Does it sound good?

Regards,
Mateusz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/