linux-kernel - Re: [PATCH] KVM: MMU: fix comment in kvm_mmu_zap_collapsible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150416081440.GA3575@kernel>
Date:	Thu, 16 Apr 2015 16:14:40 +0800
From:	Wanpeng Li <wanpeng.li@...ux.intel.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	Xiao Guangrong <guangrong.xiao@...ux.intel.com>,
	Andres Lagar-Cavilla <andreslc@...gle.com>,
	Wanpeng Li <wanpeng.li@...ux.intel.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, Eric Northup <digitaleric@...gle.com>
Subject: Re: [PATCH] KVM: MMU: fix comment in kvm_mmu_zap_collapsible_spte

On Wed, Apr 15, 2015 at 05:05:48PM +0200, Paolo Bonzini wrote:
>
>
>> -         * Only EPT supported for now; otherwise, one would need to
>> -         * find out efficiently whether the guest page tables are
>> -         * also using huge pages.
>> +         * We can not do huge page mapping for the indirect shadow
>> +         * page (sp) found on the last rmap (level = 1 ) since
>> +         * indirect sp is synced with the page table in guest and
>> +         * indirect sp->level = 1 means the guest page table is
>> +         * using 4K page size mapping.
>
>What about:
>
>+		 * We cannot do huge page mapping for indirect shadow pages,
>+		 * which are found on the last rmap (level = 1) when not using
>+		 * tdp; such shadow pages are synced with the page table in
>+		 * the guest, and the guest page table is using 4K page size
>+		 * mapping if the indirect sp has level = 1.

Reviewed-by: Wanpeng Li <wanpeng.li@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/