lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Apr 2015 08:38:24 +0800 From: Xiao Guangrong <guangrong.xiao@...ux.intel.com> To: Paolo Bonzini <pbonzini@...hat.com>, Andres Lagar-Cavilla <andreslc@...gle.com> CC: Wanpeng Li <wanpeng.li@...ux.intel.com>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, Eric Northup <digitaleric@...gle.com> Subject: Re: [PATCH] KVM: MMU: fix comment in kvm_mmu_zap_collapsible_spte On 04/15/2015 11:05 PM, Paolo Bonzini wrote: > > >> - * Only EPT supported for now; otherwise, one would need to >> - * find out efficiently whether the guest page tables are >> - * also using huge pages. >> + * We can not do huge page mapping for the indirect shadow >> + * page (sp) found on the last rmap (level = 1 ) since >> + * indirect sp is synced with the page table in guest and >> + * indirect sp->level = 1 means the guest page table is >> + * using 4K page size mapping. > > What about: > > + * We cannot do huge page mapping for indirect shadow pages, > + * which are found on the last rmap (level = 1) when not using > + * tdp; such shadow pages are synced with the page table in > + * the guest, and the guest page table is using 4K page size > + * mapping if the indirect sp has level = 1. Yeah, much better. Thanks for your improvement, Paolo! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists