linux-kernel - RE: [PATCH 5/5 v2] nvme: LightNVM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Apr 2015 09:01:35 -0700
From:	"James R. Bergsten" <jim@...bergstens.com>
To:	"'Keith Busch'" <keith.busch@...el.com>,
	'Javier González' <javier@...etta.io>
Cc:	<hch@...radead.org>,
	'Matias Bjørling' <m@...rling.me>,
	<axboe@...com>, <linux-kernel@...r.kernel.org>,
	<linux-nvme@...ts.infradead.org>, <linux-fsdevel@...r.kernel.org>
Subject: RE: [PATCH 5/5 v2] nvme: LightNVM support

My two cents worth is that it's (always) better to put ALL the commands into one place so that the entire set can be viewed at once and thus avoid inadvertent overloading of an opcode.  Otherwise you don't know what you don't know.

-----Original Message-----
From: Linux-nvme [mailto:linux-nvme-bounces@...ts.infradead.org] On Behalf Of Keith Busch
Sent: Thursday, April 16, 2015 8:52 AM
To: Javier González
Cc: hch@...radead.org; Matias Bjørling; axboe@...com; linux-kernel@...r.kernel.org; linux-nvme@...ts.infradead.org; Keith Busch; linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 5/5 v2] nvme: LightNVM support

On Thu, 16 Apr 2015, Javier González wrote:
>> On 16 Apr 2015, at 16:55, Keith Busch <keith.busch@...el.com> wrote:
>>
>> Otherwise it looks pretty good to me, but I think it would be cleaner 
>> if the lightnvm stuff is not mixed in the same file with the standard 
>> nvme command set. We might end up splitting nvme-core in the future 
>> anyway for command sets and transports.
>
> Would you be ok with having nvme-lightnvm for LightNVM specific 
> commands?

Sounds good to me, but I don't really have a dog in this fight. :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/