linux-kernel - Re: [PATCH] crypto: ensure backlog is initialised

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150418110001.GA5590@gondor.apana.org.au>
Date:	Sat, 18 Apr 2015 19:00:01 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Colin King <colin.king@...onical.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: ensure backlog is initialised

On Tue, Apr 14, 2015 at 11:51:29AM -0500, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> backlog is not initialised so in the case where
> cpg->eng_st != ENGINE_IDLE it is never initialised and
> hence which could lead to an illegal memory dereference
> in the statement:
> 
>   backlog->complete(backlog, -EINPROGRESS);
> 
> Discovered with cppcheck static analsys:
> [drivers/crypto/mv_cesa.c:616]:
>    (error) Uninitialized variable: backlog
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Patch applied.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/