linux-kernel - Re: [PATCH v2] spi: bitbang: Make setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 18 Apr 2015 12:00:55 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Pelle Nilsson <per.nilsson@...mo.com>
Cc:	ezequiel@...guardiasur.com.ar, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org, nios2-dev@...ts.rocketboards.org
Subject: Re: [PATCH v2] spi: bitbang: Make setup_transfer() callback optional

On Tue, Apr 14, 2015 at 03:40:17PM +0200, Pelle Nilsson wrote:
> Some controller drivers have no need of this callback (spi-altera even
> causes a NULL pointer dereference because it doesn't register the callback,
> falsely assuming that it is already optional).

I've applied this but really for something like this the commit message
should be explaining *why* it's reasonable for the callback to be
omitted.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)