linux-kernel - Re: [PATCH] input: cyapa: fix update suspend scanrate set to max 1000 issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Apr 2015 10:00:42 -0700
From:	Benson Leung <bleung@...gle.com>
To:	Dudley Du <dudl@...ress.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] input: cyapa: fix update suspend scanrate set to max 1000 issue

Hi Dudley.

Just a minor commit message nit. Thanks!

On Sun, Apr 19, 2015 at 10:43 PM, Dudley Du <dudl@...ress.com> wrote:
> Fix update suspend scareate always set to max 1000 issue, the root cause is
s/scareate/scanrate
> the missed using max_t as min_t.
> TEST=test on Chromebook.
>
> Signed-off-by: Dudley Du <dudl@...ress.com>

Reviewed-by: Benson Leung <bleung@...omium.org>

> ---
>  drivers/input/mouse/cyapa.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
> index 58f4f6f..efe1484 100644
> --- a/drivers/input/mouse/cyapa.c
> +++ b/drivers/input/mouse/cyapa.c
> @@ -723,7 +723,7 @@ static ssize_t cyapa_update_suspend_scanrate(struct device *dev,
>         } else if (sysfs_streq(buf, OFF_MODE_NAME)) {
>                 cyapa->suspend_power_mode = PWR_MODE_OFF;
>         } else if (!kstrtou16(buf, 10, &sleep_time)) {
> -               cyapa->suspend_sleep_time = max_t(u16, sleep_time, 1000);
> +               cyapa->suspend_sleep_time = min_t(u16, sleep_time, 1000);
>                 cyapa->suspend_power_mode =
>                         cyapa_sleep_time_to_pwr_cmd(cyapa->suspend_sleep_time);
>         } else {
> @@ -840,7 +840,7 @@ static ssize_t cyapa_update_rt_suspend_scanrate(struct device *dev,
>         if (error)
>                 return error;
>
> -       cyapa->runtime_suspend_sleep_time = max_t(u16, time, 1000);
> +       cyapa->runtime_suspend_sleep_time = min_t(u16, time, 1000);
>         cyapa->runtime_suspend_power_mode =
>                 cyapa_sleep_time_to_pwr_cmd(cyapa->runtime_suspend_sleep_time);
>
> --
> 1.9.1
>



-- 
Benson Leung
Software Engineer, Chrome OS
Google Inc.
bleung@...gle.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/