linux-kernel - Re: [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ34Pp7sufWV9J9SSGcy0NrhdWosXHHu1Dk7GCCboV9SmBhEWA@mail.gmail.com>
Date:	Mon, 20 Apr 2015 10:02:12 -0700
From:	Charles Mooney <charliemooney@...omium.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, Scott Liu <scott.liu@....com.tw>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name

On Fri, Apr 17, 2015 at 8:43 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> Let's zero-extend hardware id number when forming firmware file name,
> to avoid kernel requesting firmware like "elants_i2c_   0.bin", which
> is quite unexpected.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>  drivers/input/touchscreen/elants_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
> index 43b3c9c..0efd766 100644
> --- a/drivers/input/touchscreen/elants_i2c.c
> +++ b/drivers/input/touchscreen/elants_i2c.c
> @@ -699,7 +699,7 @@ static int elants_i2c_fw_update(struct elants_data *ts)
>         char *fw_name;
>         int error;
>
> -       fw_name = kasprintf(GFP_KERNEL, "elants_i2c_%4x.bin", ts->hw_version);
> +       fw_name = kasprintf(GFP_KERNEL, "elants_i2c_%04x.bin", ts->hw_version);
>         if (!fw_name)
>                 return -ENOMEM;
>
> --
> 2.2.0.rc0.207.ga3a616c
>
>
> --
> Dmitry

Looks good to me.

Acked-by: Charlie Mooney<charliemooney@...omium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/