linux-kernel - Re: [PATCH] ARM: at91/dt: kizbox: update and rename to at91-kizbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5536208E.4060105@overkiz.com>
Date:	Tue, 21 Apr 2015 12:03:58 +0200
From:	Gaël PORTAY <g.portay@...rkiz.com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>
CC:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: at91/dt: kizbox: update and rename to at91-kizbox

On 21/04/2015 09:11, Boris Brezillon wrote:
> Hi Gael,
>
> On Mon, 20 Apr 2015 11:13:38 +0200
> Gaël PORTAY <g.portay@...rkiz.com> wrote:
>
>> Sort nodes, rename to match Atmel naming convention
> You should use -M when you generate your patches with format-patch: it
> keeps track of files that have been renamed instead of considering it
> as a removal + an addition.

Ok, thanks, I did not know that option...

>> and update the features
>> below:
>>   - command-line,
>>   - use proper serial uart,
>>   - rename leds and gpio-keys,
>>   - update to pwm-leds and
>>   - fix gpio-key level.
> Please split this patch so we can easily review the changes.
> How about the following separation ?
>
> - rename dts file
> - use stdout-path
> - sanitize bootargs
> - led related changes (rename + pwm-leds)
> - gpio-key related changes (rename + fix level)

In fact, each changes were committed in single patch before I submitted 
them...

I just squashed them thinking it would be easier for you to check (only) 
for the "new" device-tree.... my bad :(

What about the node re-order? Do you prefer in dedicated commit or with 
the rename patch?

> Best Regards,
>
> Boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/