linux-kernel - Re: [PATCH v2] tpm: enable PPI for TPM 2.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150421185825.GA8366@roeck-us.net>
Date:	Tue, 21 Apr 2015 11:58:33 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:	peterhuewe@....de, tpmdd-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Marcel Selhorst <tpmdd@...horst.net>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tejun Heo <tj@...nel.org>, Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jianyu Zhan <nasa4836@...il.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Andrzej Hajda <a.hajda@...sung.com>, NeilBrown <neilb@...e.de>,
	Simon Wunderlich <sw@...onwunderlich.de>
Subject: Re: [PATCH v2] tpm: enable PPI for TPM 2.0

On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote:
> Enabled PPI interface to the character device sysfs directory accessible
> both for 1.x and 2.0 devices.
> 
> The ppi group is moved from the platform device directory to the
> character device directory. In order to retain backwards compatibility
> with the 1.x devices, a symlink is created to the platform device
> directory.
> 
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> Reviewed-by: Jason Gunthorpe <jason.gunthorpe@...idianresearch.com>
> ---
>  drivers/char/tpm/tpm-chip.c | 21 +++++++++++++--------
>  drivers/char/tpm/tpm.h      | 17 ++++++-----------
>  drivers/char/tpm/tpm_ppi.c  | 34 +++++++++++-----------------------
>  fs/kernfs/dir.c             |  1 +
>  fs/sysfs/group.c            | 42 ++++++++++++++++++++++++++++++++++++++++++
>  include/linux/sysfs.h       |  8 ++++++++

Shouldn't the sysfs changes be a separate patch ?

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/