linux-kernel - Re: [PATCH v2] x86/asm/entry/64: 32-bit execve stubs are identical to x32 ones, merge them.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMzpN2iSs2MdKLFw=oFTe0OFBSKUjMvSAvOCeOaJU7OGg2VP8A@mail.gmail.com>
Date:	Wed, 22 Apr 2015 10:07:55 -0400
From:	Brian Gerst <brgerst@...il.com>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Borislav Petkov <bp@...en8.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andy Lutomirski <luto@...capital.net>,
	Oleg Nesterov <oleg@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Will Drewry <wad@...omium.org>,
	Kees Cook <keescook@...omium.org>,
	"the arch/x86 maintainers" <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] x86/asm/entry/64: 32-bit execve stubs are identical to
 x32 ones, merge them.

On Tue, Apr 21, 2015 at 12:03 PM, Denys Vlasenko <dvlasenk@...hat.com> wrote:
> Siggested by Brian Gerst.

Suggested

>
> Run-tested.
>
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> CC: Linus Torvalds <torvalds@...ux-foundation.org>
> CC: Steven Rostedt <rostedt@...dmis.org>
> CC: Ingo Molnar <mingo@...nel.org>
> CC: Borislav Petkov <bp@...en8.de>
> CC: "H. Peter Anvin" <hpa@...or.com>
> CC: Andy Lutomirski <luto@...capital.net>
> CC: Oleg Nesterov <oleg@...hat.com>
> CC: Frederic Weisbecker <fweisbec@...il.com>
> CC: Alexei Starovoitov <ast@...mgrid.com>
> CC: Will Drewry <wad@...omium.org>
> CC: Kees Cook <keescook@...omium.org>
> CC: x86@...nel.org
> CC: linux-kernel@...r.kernel.org
> ---
>
> Changes in v2: fixed "suggested by", I remebered it wrongly.
>
>  arch/x86/kernel/entry_64.S | 23 +++++------------------
>  1 file changed, 5 insertions(+), 18 deletions(-)
>
> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> index c7b2384..3bdfdcd 100644
> --- a/arch/x86/kernel/entry_64.S
> +++ b/arch/x86/kernel/entry_64.S
> @@ -524,40 +524,27 @@ GLOBAL(stub_execveat)
>         CFI_ENDPROC
>  END(stub_execveat)
>
> -#ifdef CONFIG_X86_X32_ABI
> +#if defined(CONFIG_X86_X32_ABI) || defined(CONFIG_IA32_EMULATION)
>         .align  8
>  GLOBAL(stub_x32_execve)
> +GLOBAL(stub32_execve)
>         CFI_STARTPROC
>         DEFAULT_FRAME 0, 8
>         call    compat_sys_execve
>         jmp     return_from_execve
>         CFI_ENDPROC
> +END(stub32_execve)
>  END(stub_x32_execve)
>         .align  8
>  GLOBAL(stub_x32_execveat)
> -       CFI_STARTPROC
> -       DEFAULT_FRAME 0, 8
> -       call    compat_sys_execveat
> -       jmp     return_from_execve
> -       CFI_ENDPROC
> -END(stub_x32_execveat)
> -#endif
> -
> -#ifdef CONFIG_IA32_EMULATION
> -       .align  8
> -GLOBAL(stub32_execve)
> -       CFI_STARTPROC
> -       call    compat_sys_execve
> -       jmp     return_from_execve
> -       CFI_ENDPROC
> -END(stub32_execve)
> -       .align  8
>  GLOBAL(stub32_execveat)
>         CFI_STARTPROC
> +       DEFAULT_FRAME 0, 8
>         call    compat_sys_execveat
>         jmp     return_from_execve
>         CFI_ENDPROC
>  END(stub32_execveat)
> +END(stub_x32_execveat)
>  #endif
>
>  /*

I don't think it's necessary to keep both labels.  Just use one and
change the syscall tables accordingly.  Otherwise, looks good.

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/