linux-kernel - Re: [PATCH 2/6] mtd: diskonchip: don't call nand_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACna6rxihkdinPOiHJ5-C2LO9uELmR-4j-0ULOWTY9Z_Nre24A@mail.gmail.com>
Date:	Thu, 23 Apr 2015 09:50:08 +0200
From:	Rafał Miłecki <zajec5@...il.com>
To:	Peter Pan 潘栋 (peterpandong) 
	<peterpandong@...ron.com>
Cc:	Brian Norris <computersforpeace@...il.com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6] mtd: diskonchip: don't call nand_scan_bbt() directly

On 23 April 2015 at 02:30, Peter Pan 潘栋 (peterpandong)
<peterpandong@...ron.com> wrote:
> On Thu, Apr 23, 2015 at 01:51:27PM +0000, Brian Norris wrote:
>>
>> On Thu, Apr 16, 2015 at 02:11:24AM +0000, Peter Pan 潘栋 (peterpandong)
>> wrote:
>> > The diskonchip driver almost uses the default nand_base hooks as-is,
>> > except that it provides custom on-flash BBT descriptors and avoids
>> using
>> > factory-marked bad blockers.
>> >
>> > So let's refactor the BBT initialization code into a private
>> 'late_init'
>> > hook which handles all the private details. Note the usage of
>> > NAND_SKIP_BBTSCAN, which allows us to defer the BBT scan until we've
>> > prepared everything.
>> >
>> > Signed-off-by: Brian Norris <computersforpeace@...il.com>
>> > Signed-off-by: Peter Pan <peterpandong@...ron.com>
>>
>> Why are you just resending my patch? You could Ack/Review/Test it
>> instead. (Did you test it?)
>
> My work is in the 6th patch.
> I already tested the patch with micron own nand controller. I don't have
> platform with docg4 or diskonchip controller. So the BBT and nand_base.c
> part is covered while docg4.c and diskonchip.c not.

You can use patch format's comment place to post sth like
"Depends on 5 XXX patches from Brian"

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/