linux-kernel - Re: [PATCH v5 4/8] vringh: introduce vringh_is_little

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150423210058.70f113ef@thh440s>
Date:	Thu, 23 Apr 2015 21:00:58 +0200
From:	Thomas Huth <thuth@...hat.com>
To:	Greg Kurz <gkurz@...ux.vnet.ibm.com>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH v5 4/8] vringh: introduce vringh_is_little_endian()
 helper

On Thu, 23 Apr 2015 17:26:52 +0200
Greg Kurz <gkurz@...ux.vnet.ibm.com> wrote:

> Signed-off-by: Greg Kurz <gkurz@...ux.vnet.ibm.com>
> ---
>  include/linux/vringh.h |   17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/include/linux/vringh.h b/include/linux/vringh.h
> index a3fa537..3ed62ef 100644
> --- a/include/linux/vringh.h
> +++ b/include/linux/vringh.h
> @@ -226,33 +226,38 @@ static inline void vringh_notify(struct vringh *vrh)
>  		vrh->notify(vrh);
>  }
>  
> +static inline bool vringh_is_little_endian(const struct vringh *vrh)
> +{
> +	return vrh->little_endian;
> +}
> +
>  static inline u16 vringh16_to_cpu(const struct vringh *vrh, __virtio16 val)
>  {
> -	return __virtio16_to_cpu(vrh->little_endian, val);
> +	return __virtio16_to_cpu(vringh_is_little_endian(vrh), val);
>  }
>  
>  static inline __virtio16 cpu_to_vringh16(const struct vringh *vrh, u16 val)
>  {
> -	return __cpu_to_virtio16(vrh->little_endian, val);
> +	return __cpu_to_virtio16(vringh_is_little_endian(vrh), val);
>  }
>  
>  static inline u32 vringh32_to_cpu(const struct vringh *vrh, __virtio32 val)
>  {
> -	return __virtio32_to_cpu(vrh->little_endian, val);
> +	return __virtio32_to_cpu(vringh_is_little_endian(vrh), val);
>  }
>  
>  static inline __virtio32 cpu_to_vringh32(const struct vringh *vrh, u32 val)
>  {
> -	return __cpu_to_virtio32(vrh->little_endian, val);
> +	return __cpu_to_virtio32(vringh_is_little_endian(vrh), val);
>  }
>  
>  static inline u64 vringh64_to_cpu(const struct vringh *vrh, __virtio64 val)
>  {
> -	return __virtio64_to_cpu(vrh->little_endian, val);
> +	return __virtio64_to_cpu(vringh_is_little_endian(vrh), val);
>  }
>  
>  static inline __virtio64 cpu_to_vringh64(const struct vringh *vrh, u64 val)
>  {
> -	return __cpu_to_virtio64(vrh->little_endian, val);
> +	return __cpu_to_virtio64(vringh_is_little_endian(vrh), val);
>  }
>  #endif /* _LINUX_VRINGH_H */

Reviewed-by: Thomas Huth <thuth@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/