linux-kernel - Re: [PATCHv3 08/11] usb: dwc3: add hsphy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Apr 2015 11:04:12 +0300
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	Felipe Balbi <balbi@...com>
Cc:	David Cohen <david.a.cohen@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Baolu Lu <baolu.lu@...ux.intel.com>,
	Paul Bolle <pebolle@...cali.nl>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 08/11] usb: dwc3: add hsphy_interface property

> > +	/* Select the HS PHY interface */
> > +	switch (DWC3_GHWPARAMS3_HSPHY_IFC(dwc->hwparams.hwparams3)) {
> > +	case DWC3_GHWPARAMS3_HSPHY_IFC_UTMI_ULPI:
> > +		if (!strncmp(dwc->hsphy_interface, "utmi", 4)) {
> > +			reg &= ~DWC3_GUSB2PHYCFG_ULPI_UTMI;
> > +		} else if (!strncmp(dwc->hsphy_interface, "ulpi", 4)) {
> > +			reg |= DWC3_GUSB2PHYCFG_ULPI_UTMI;
> > +		} else {
> > +			dev_err(dwc->dev, "HSPHY Interface not defined\n");
> > +			return -EINVAL;
> 
> instead of erroring out, just leave default value and convert this to a
> dev_warn() or something similar. That way, older DTS will continue to
> work.

OK, I'll change it.

Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/