linux-kernel - Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1625165.pchJQFHZZe@xps13>
Date:	Wed, 29 Apr 2015 13:51:21 +0200
From:	Gabriele Mazzotta <gabriele.mzt@...il.com>
To:	jic23@...nel.org
Cc:	knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
	marxin.liska@...il.com, marex@...x.de, rui.zhang@...el.com,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

On Wednesday 29 April 2015 13:27:25 Gabriele Mazzotta wrote:
> Add basic implementation of the ACPI0008 Ambient Light Sensor driver.
> This driver currently supports only the ALI property, yet is ready to
> be easily extended to handle ALC, ALT, ALP ones as well.
> 
> Signed-off-by: Martin Liska <marxin.liska@...il.com>
> Signed-off-by: Marek Vasut <marex@...x.de>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>
> Cc: Zhang Rui <rui.zhang@...el.com>
> ---
> This continues http://marc.info/?t=140163463200002
> I've made few adjustments over the original patch:
> 
>  - Code aligned with 4.1-rc1 and cleaned up
>  - Use signed integers to store values: sensors report 32bit signed
>    values. In particular, -1 is reported when the current reading
>    is above the supported range of sensitivity.
> 
> Most of the changes are just a consequence of the changes in the
> iio subsystem.
> 
> Gabriele

I'm sorry, I've just noticed that I haven't changed the value of
realbits in acpi_als_channels. This makes me wonder what would be the
proper value, given that this is a generic driver and all the
information I have are those in the ACPI specification (which states
what I reported here above).

Should I just set realbits to 32?

Thanks,
Gabriele
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/