linux-kernel - Re: [PATCH v8 2/3] scsi: ufs: add debugfs for ufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 29 Apr 2015 07:43:14 -0700
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Gilad Broner <gbroner@...eaurora.org>
Cc:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, santoshsy@...il.com,
	linux-scsi-owner@...r.kernel.org, subhashj@...eaurora.org,
	ygardi@...eaurora.org, draviv@...eaurora.org,
	Lee Susman <lsusman@...eaurora.org>,
	Raviv Shvili <rshvili@...eaurora.org>,
	Vinayak Holikatti <vinholikatti@...il.com>
Subject: Re: [PATCH v8 2/3] scsi: ufs: add debugfs for ufs

On Tue, 2015-04-14 at 14:51 +0300, Gilad Broner wrote:
> From: Lee Susman <lsusman@...eaurora.org>
> 
> Adding debugfs capability for ufshcd.
> 
> debugfs attributes introduced in this patch:
>  - View driver/controller runtime data
>  - Command tag statistics for performance analisis
>  - Dump device descriptor info
>  - Track recoverable errors statistics during runtime
>  - Change UFS power mode during runtime
>      entry a string in the format 'GGLLMM' where:
>          G - selected gear
>          L - number of lanes
>          M - power mode
>              (1=fast mode, 2=slow mode, 4=fast-auto mode,
>               5=slow-auto mode)
>      First letter is for RX, second is for TX.
>  - Get/set DME attributes
> 
> Signed-off-by: Lee Susman <lsusman@...eaurora.org>
> Signed-off-by: Dolev Raviv <draviv@...eaurora.org>
> Signed-off-by: Yaniv Gardi <ygardi@...eaurora.org>
> Signed-off-by: Raviv Shvili <rshvili@...eaurora.org>
> Signed-off-by: Gilad Broner <gbroner@...eaurora.org>

Bloody test your damn changes.  That means running them through a config
options permutation when you introduce config dependencies.

This is what happens with CONFIG_DEBUG_FS=n:

        drivers/scsi/ufs/ufshcd.c:92:9: warning: ‘struct scsi_cmd’
        declared inside parameter list [enabled by default]
          struct scsi_cmd *cmd)
                 ^
        drivers/scsi/ufs/ufshcd.c:92:9: warning: its scope is only this
        definition or declaration, which is probably not what you want
        [enabled by default]

That's a typo inside the other branch of the #ifdef ... apparently none
of your reviewers spotted it either.

        drivers/scsi/ufs/ufs-debugfs.c: In function
        ‘ufsdbg_tag_stats_show’:
        drivers/scsi/ufs/ufs-debugfs.c:60:18: error: ‘struct ufs_hba’
        has no member named ‘ufs_stats’
          ufs_stats = &hba->ufs_stats;
                          ^
        ...
        
This lot is obvious: ufs-debufs should not be compiled at all if
CONFIG_DEBUG_FS=n

>From now on, I'm not taking your code unless it has an external reviewer
who makes sure I don't keep running across crap like this.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/