linux-kernel - Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150429130852.487100d9@gandalf.local.home>
Date:	Wed, 29 Apr 2015 13:08:52 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Shreyas B Prabhu <shreyas@...ux.vnet.ibm.com>
Cc:	Preeti Murthy <preeti.lkml@...il.com>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	aneesh.kumar@...ux.vnet.ibm.com,
	Preeti U Murthy <preeti@...ux.vnet.ibm.com>
Subject: Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on
 offline cpus

On Wed, 29 Apr 2015 21:28:38 +0530
Shreyas B Prabhu <shreyas@...ux.vnet.ibm.com> wrote:

> 
> 
> On Wednesday 29 April 2015 08:48 PM, Steven Rostedt wrote:
> > On Wed, 29 Apr 2015 20:19:28 +0530
> > Shreyas B Prabhu <shreyas@...ux.vnet.ibm.com> wrote:
> > 
> >> IIUC there is no existing macro which can both add a condition and
> >> override printk format, hence the fall back to TRACE_EVENT_CONDITION.
> > 
> > Hmm, want me to send you a patch that changes that?
> > 
> I am not sure if its worth the effort now. It doesn't look like any
> other trace point apart from the above use case will benefit from it.
> Only smbus_write and smbus_reply seem to come close. But even they need
> separate TP_fast_assign.

It shouldn't be a problem to implement. But I'm currently cleaning up
those files, and any changes will cause nasty conflicts.

Lets do this. Push the current changes as is, and when I get around to
adding a DEFINE_EVENT_PRINT_CONDITION(), we can modify that code to use
it.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/