linux-kernel - Re: [PATCH] net: dsa: Fix scope of eeprom-length property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150429180759.GF6504@lunn.ch>
Date:	Wed, 29 Apr 2015 20:07:59 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: Fix scope of eeprom-length property

On Wed, Apr 29, 2015 at 10:56:15AM -0700, Guenter Roeck wrote:
> eeprom-length is a switch property, not a dsa property, and thus
> needs to be attached to the switch node, not to the dsa node.
> 
> Reported-by: Andrew Lunn <andrew@...n.ch>
> Fixes: 6793abb4e849 ("net: dsa: Add support for switch EEPROM access")
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Acked-by: Andrew Lunn <andrew@...n.ch?

Thanks
	Andrew

> ---
>  net/dsa/dsa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
> index 079a224471e7..e6f6cc3a1bcf 100644
> --- a/net/dsa/dsa.c
> +++ b/net/dsa/dsa.c
> @@ -633,7 +633,7 @@ static int dsa_of_probe(struct device *dev)
>  		if (cd->sw_addr > PHY_MAX_ADDR)
>  			continue;
>  
> -		if (!of_property_read_u32(np, "eeprom-length", &eeprom_len))
> +		if (!of_property_read_u32(child, "eeprom-length", &eeprom_len))
>  			cd->eeprom_len = eeprom_len;
>  
>  		for_each_available_child_of_node(child, port) {
> -- 
> 2.1.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/