linux-kernel - Re: [PATCH] perf tools: Fix bison-related build failure on CentOS 6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150429181414.GA14167@krava.redhat.com>
Date:	Wed, 29 Apr 2015 20:14:14 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	Namhyung Kim <namhyung@...nel.org>, Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf tools: Fix bison-related build failure on CentOS 6

On Wed, Apr 29, 2015 at 07:57:05PM +0200, Jiri Olsa wrote:
> On Wed, Apr 29, 2015 at 01:27:40PM -0300, Arnaldo Carvalho de Melo wrote:
> > > The YYLTYPE_IS_TRIVIAL is defined in the Build file, but unlike
> > > pmu-bison.c, gcc complained about it for parse-events-bison.c:
> > > 
> > >     CC       util/parse-events-bison.o
> > >   In file included from util/parse-events.y:16:
> > >   util/parse-events-bison.h:101:1: error: "YYLTYPE_IS_TRIVIAL" redefined
> > >   <command-line>: error: this is the location of the previous definition
> > >   make[3]: *** [util/parse-events-bison.o] Error 1
> > > 
> > > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> > 
> > Ok, so this helps, it builds now on RHEL6.6, which was something I and
> > Jiri were chasing, but why has it complained for one and not the other?
> > Ideas?
> 
> looks like the RHEL6 gcc/cpp treats this as an error which
> is not maskable by '-w' option
> 
> anyway I checked the git log history and I'm not sure
> why we event have this define, it was added by Ingo
> and carried by ever since:
> 
>   65f3e56e0c81 perf tools: Remove auto-generated bison/flex files
> 
> probably because of the fail I see if I remove it from pmu-bison.o build:
> 
>   util/pmu-bison.c:613:6: error: "YYLTYPE_IS_TRIVIAL" is not defined

ok, seem's the patch is right and the reason is the
parse error handling that was added just recently

it adds YYLTYPE type (which is not present in pmu-bison.h),
so YYLTYPE_IS_TRIVIAL gets redefined, which is ok in F20
that handle the error via '-w' option, but it's not ok for RHEL6
where the '-w' does not work for this kind of error

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/