linux-kernel - Re: [Linux-nvdimm] [PATCH v2 11/20] libnd, nd_pmem: add libnd support to the pmem driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrVtbT6jAKHgqYzu1zY2=7gcb5_A9z1pOge9Q7tndsmGhA@mail.gmail.com>
Date:	Wed, 29 Apr 2015 11:36:29 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	Phil Pokorny <ppokorny@...guincomputing.com>,
	linux-nvdimm <linux-nvdimm@...ts.01.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...com>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [Linux-nvdimm] [PATCH v2 11/20] libnd, nd_pmem: add libnd support
 to the pmem driver

On Wed, Apr 29, 2015 at 8:55 AM, Dan Williams <dan.j.williams@...el.com> wrote:
> On Tue, Apr 28, 2015 at 3:58 PM, Andy Lutomirski <luto@...capital.net> wrote:
>> On Tue, Apr 28, 2015 at 3:21 PM, Phil Pokorny
>> <ppokorny@...guincomputing.com> wrote:
>>> On Tue, Apr 28, 2015 at 2:04 PM, Andy Lutomirski <luto@...capital.net> wrote:
>>>> On Tue, Apr 28, 2015 at 11:25 AM, Dan Williams <dan.j.williams@...el.com> wrote:
> [..]
>> This is such a mess that I think this driver should maybe flat-out
>> refuse to load in this type of configuration without some scary module
>> option.  I have some NVDIMMs that report as type 12 but need two extra
>> out-of-tree drivers to work safely.  First, they need i2c_imc or the
>> equivalent (I'll try to resubmit that soon).  Second, they need secret
>> magic NDAed register poking.  The latter is very problematic.
>>
>> At the very least, I think we should discourage people who don't
>> really know what they're doing from using this driver without care.
>
> The benefit of the type-12 experiment having not made it very far out
> of the lab is that it may be feasible to whitelist known platforms
> where we believe ADR is available.  Otherwise, the presence of the
> NFIT asserts platform persistent memory support.

This could be a good idea.  I'm planning on resubmitting my i2c driver
in the next couple weeks, and maybe I'll whitelist my own platform :)

--Andy

-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/