linux-kernel - Re: [PATCH 1/2] UV: NMI: insert per_cpu accessor function on uv_hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150501072126.GC19852@gmail.com>
Date:	Fri, 1 May 2015 09:21:26 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	George Beshers <gbeshers@....com>
Cc:	Mike Travis <travis@....com>, linux-kernel@...r.kernel.org,
	Alex Thorlton <athorlton@....com>,
	Dimitri Sivanich <sivanich@....com>,
	Ingo Molnar <mingo@...hat.com>, Hedi Berriche <hedi@....com>,
	Russ Anderson <rja@....com>
Subject: Re: [PATCH 1/2] UV: NMI: insert per_cpu accessor function on
 uv_hub_nmi.


* George Beshers <gbeshers@....com> wrote:

> UV: NMI: insert this_cpu_read accessor function on uv_hub_nmi.
> 
> UV NMI was accidently broken by this patch.

Broken in what way?

>     commit e16321709c8270f9803bbfdb51e5e02235078c7f
>     Author: Christoph Lameter <cl@...ux.com>
>     Date:   Sun Aug 17 12:30:41 2014 -0500

That's a rather old patch. Was no upstream kernel tested since ~August 
last year on UV hardware, or is the bug sporadic? The changelog does 
not tell us.

> This patch insert this_cpu_read() on when accessing the PER_CPU 
> uv_cpu_nmi variable.

Why? What problem does it solve?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/