[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55439734.1070709@linux.intel.com>
Date: Fri, 01 May 2015 08:09:40 -0700
From: Dave Hansen <dave.hansen@...ux.intel.com>
To: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>,
tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
tony.luck@...el.com, bp@...en8.de, jiang.liu@...ux.intel.com,
yinghai@...nel.org
CC: x86@...nel.org, dvlasenk@...hat.com, JBeulich@...e.com,
slaoub@...il.com, luto@...capital.net, oleg@...hat.com,
rostedt@...dmis.org, rusty@...tcorp.com.au, prarit@...hat.com,
linux@...musvillemoes.dk, jroedel@...e.de,
andriy.shevchenko@...ux.intel.com, macro@...ux-mips.org,
wangnan0@...wei.com, linux-kernel@...r.kernel.org,
linux-edac@...r.kernel.org
Subject: Re: [PATCH 1/4] x86/mce: Define 'SUCCOR' cpuid bit
On 04/30/2015 07:49 AM, Aravind Gopalakrishnan wrote:
> @@ -1640,6 +1640,7 @@ static void __mcheck_cpu_init_vendor(struct cpuinfo_x86 *c)
> case X86_VENDOR_AMD:
> mce_amd_feature_init(c);
> mce_flags.overflow_recov = cpuid_ebx(0x80000007) & 0x1;
> + mce_flags.succor = (cpuid_ebx(0x80000007) & 0x2) ? 1 : 0;
> break;
> default:
> break;
Is there a reason to add the cpuid detection like this instead of adding
an X86_FEATURE_ for it and using cpu_has() and friends? Doing that
would also let you see the bit in /proc/cpuinfo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists