linux-kernel - Re: [PATCH] x86/fpu: always restore_xinit_state() when !use_eager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5543C277.9070208@intel.com>
Date:	Fri, 01 May 2015 11:14:15 -0700
From:	Dave Hansen <dave.hansen@...el.com>
To:	Bobby Powers <bobbypowers@...il.com>, linux-kernel@...r.kernel.org
CC:	x86@...nel.org, Oleg Nesterov <oleg@...hat.com>,
	Borislav Petkov <bp@...e.de>, Ingo Molnar <mingo@...nel.org>,
	Andy Lutomirski <luto@...capital.net>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Pekka Riikonen <priikone@....fi>,
	Quentin Casasnovas <quentin.casasnovas@...cle.com>,
	Rik van Riel <riel@...hat.com>,
	Suresh Siddha <sbsiddha@...il.com>,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] x86/fpu: always restore_xinit_state() when !use_eager_cpu()

On 04/27/2015 07:46 AM, Dave Hansen wrote:
>> > static inline void restore_init_xstate(void)
>> > {
>> >         if (use_xsave())
>> >                 xrstor_state(init_xstate_buf, -1);
>> >         else
>> >                 fxrstor_checking(&init_xstate_buf->i387);
>> > }
> I'll do some testing of this today and make sure it doesn't break the
> things that I saw Oleg's patch "fix".

This looks OK to me.  You can add my tested-by if you like.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/