linux-kernel - Re: [patch] ARM: fix module-bound check in setting page attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5543C529.4080203@labbott.name>
Date:	Fri, 01 May 2015 11:25:45 -0700
From:	Laura Abbott <laura@...bott.name>
To:	Hillf Danton <hillf.zj@...baba-inc.com>
CC:	'Russell King' <rmk+kernel@....linux.org.uk>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux@....linux.org.uk
Subject: Re: [patch] ARM: fix module-bound check in setting page attributes



On 3/24/15 9:20 PM, Hillf Danton wrote:
> It was introduced in commit f2ca09f381a59
> (ARM: 8311/1: Don't use is_module_addr in setting page attributes)
>
> We have no need to check start twice, but see if end is also in range.
>
> Signed-off-by: Hillf Danton <hillf.zj@...baba-inc.com>
> ---
>
> --- a/arch/arm/mm/pageattr.c	Wed Mar 25 11:55:13 2015
> +++ b/arch/arm/mm/pageattr.c	Wed Mar 25 11:57:31 2015
> @@ -52,7 +52,7 @@ static int change_memory_common(unsigned
>   	if (start < MODULES_VADDR || start >= MODULES_END)
>   		return -EINVAL;
>
> -	if (end < MODULES_VADDR || start >= MODULES_END)
> +	if (end < MODULES_VADDR || end >= MODULES_END)
>   		return -EINVAL;
>
>   	data.set_mask = set_mask;
> --
>
>

Sorry for the delay, that e-mail address is being phased out.
Please remember to Cc linux-arm-kernel when sending anything
in arch/arm. If this hasn't been picked up, please resend
with linux-arm-kernel Cc'ed and you can add

Acked-by: Laura Abbott <laura@...bott.name>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/