linux-kernel - [patch] ARM: fix module-bound check in setting page attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <019401d08615$5e093000$1a1b9000$@alibaba-inc.com>
Date:	Mon, 04 May 2015 10:52:31 +0800
From:	"Hillf Danton" <hillf.zj@...baba-inc.com>
To:	"'Laura Abbott'" <laura@...bott.name>
Cc:	"'Russell King'" <rmk+kernel@....linux.org.uk>,
	"'linux-kernel'" <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: [patch] ARM: fix module-bound check in setting page attributes

It was introduced in commit f2ca09f381a59
(ARM: 8311/1: Don't use is_module_addr in setting page attributes)

We have no need to check start twice, but see if end is also in range.

Signed-off-by: Hillf Danton <hillf.zj@...baba-inc.com>
Acked-by: Laura Abbott <laura@...bott.name>
---

--- a/arch/arm/mm/pageattr.c	Mon May  4 10:33:49 2015
+++ b/arch/arm/mm/pageattr.c	Mon May  4 10:35:32 2015
@@ -52,7 +52,7 @@ static int change_memory_common(unsigned
 	if (start < MODULES_VADDR || start >= MODULES_END)
 		return -EINVAL;
 
-	if (end < MODULES_VADDR || start >= MODULES_END)
+	if (end < MODULES_VADDR || end >= MODULES_END)
 		return -EINVAL;
 
 	data.set_mask = set_mask;
--


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/