linux-kernel - Re: [PATCH v2 10/21] staging: rtl8192e: replace memcpy() -> ether_addr_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150503191033.GA12930@kroah.com>
Date:	Sun, 3 May 2015 21:10:33 +0200
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 10/21] staging: rtl8192e: replace memcpy() ->
 ether_addr_copy_unaligned()

On Mon, Apr 13, 2015 at 11:47:33PM +0200, Mateusz Kulikowski wrote:
> rtl8192e driver uses memcpy() to copy hw addresses in several places.
> checkpatch.pl suggests to use ether_addr_copy(), but most of
> addresses in driver may be unaligned.
> This patch replaces all memcpy occurences with single macro therby
> silencing checkpatch.pl (single complaints in macro remains).
> 
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@...il.com>
> ---
>  drivers/staging/rtl8192e/rtl819x_BAProc.c    | 12 ++---
>  drivers/staging/rtl8192e/rtllib.h            |  3 ++
>  drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 18 +++----
>  drivers/staging/rtl8192e/rtllib_rx.c         | 74 +++++++++++++++++-----------
>  drivers/staging/rtl8192e/rtllib_softmac.c    | 67 +++++++++++++------------
>  drivers/staging/rtl8192e/rtllib_softmac_wx.c |  5 +-
>  drivers/staging/rtl8192e/rtllib_tx.c         | 24 ++++-----
>  7 files changed, 113 insertions(+), 90 deletions(-)

I've stopped applying here, no need to resend the first 9 of these
patches for your next round.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/