linux-kernel - Re: [RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150504122619.GS15510@sirena.org.uk>
Date:	Mon, 4 May 2015 13:26:19 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	Patrick Lai <plai@...eaurora.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Banajit Goswami <bgoswami@...eaurora.org>,
	Kenneth Westfield <kwestfie@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, linux-arm-msm@...r.kernel.org
Subject: Re: [RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass
 variant

On Thu, Apr 30, 2015 at 06:17:24PM +0100, Srinivas Kandagatla wrote:

> +	if (!drvdata->variant->no_osr_clk) {
> +		ret = clk_prepare_enable(drvdata->mi2s_osr_clk[dai->id]);

Can we do this by checking to see if the clock is set to IS_ERR()
instead?  That's what we're doing elsewhere for possibly optional
clocks.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)