linux-kernel - Re: [RFT][PATCH 2/2] regulator: max77843: Convert to use regulator_is_enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150504122810.GT15510@sirena.org.uk>
Date:	Mon, 4 May 2015 13:28:10 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Krzysztof Kozłowski <k.kozlowski.k@...il.com>
Cc:	Axel Lin <axel.lin@...ics.com>,
	Jaewon Kim <jaewon02.kim@...sung.com>,
	Beomho Seo <beomho.seo@...sung.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFT][PATCH 2/2] regulator: max77843: Convert to use
 regulator_is_enabled_regmap

On Fri, May 01, 2015 at 04:54:08PM +0900, Krzysztof Kozłowski wrote:
> 2015-05-01 15:17 GMT+09:00 Axel Lin <axel.lin@...ics.com>:

> > Use regulator_is_enabled_regmap() to replace max77843_reg_is_enabled().

> I did not update the max77843 driver with such change (as did for max77693)
> because I think they should be merged:
> https://lkml.org/lkml/2015/4/29/185
> These devices are almost the same.

I can't see that link since I don't have internet access right now but
surely it's going to be clearer that the code for the devices is the
same if we make updates like this to both devices?  Otherwise it's less
obvious on review.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)