linux-kernel - Re: [RFT][PATCH 2/2] regulator: max77843: Convert to use regulator_is_enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPd8E=sR+w6bBUTwTYv7Kpc5NW-9dAmPgsO3=h_Ba31ahg@mail.gmail.com>
Date:	Mon, 4 May 2015 22:56:36 +0900
From:	Krzysztof Kozłowski <k.kozlowski.k@...il.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Axel Lin <axel.lin@...ics.com>,
	Jaewon Kim <jaewon02.kim@...sung.com>,
	Beomho Seo <beomho.seo@...sung.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFT][PATCH 2/2] regulator: max77843: Convert to use regulator_is_enabled_regmap

2015-05-04 21:28 GMT+09:00 Mark Brown <broonie@...nel.org>:
> On Fri, May 01, 2015 at 04:54:08PM +0900, Krzysztof Kozłowski wrote:
>> 2015-05-01 15:17 GMT+09:00 Axel Lin <axel.lin@...ics.com>:
>
>> > Use regulator_is_enabled_regmap() to replace max77843_reg_is_enabled().
>
>> I did not update the max77843 driver with such change (as did for max77693)
>> because I think they should be merged:
>> https://lkml.org/lkml/2015/4/29/185
>> These devices are almost the same.
>
> I can't see that link since I don't have internet access right now but
> surely it's going to be clearer that the code for the devices is the
> same if we make updates like this to both devices?  Otherwise it's less
> obvious on review.

Yes, indeed. The patch itself looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@...il.com>

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/