linux-kernel - Re: [PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150504135726.GB15510@sirena.org.uk>
Date:	Mon, 4 May 2015 14:57:26 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Kevin Cernekee <cernekee@...omium.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Lars-Peter Clausen <lars@...afoo.de>, dgreid@...omium.org,
	Andrew Bresticker <abrestic@...omium.org>,
	Olof Johansson <olofj@...omium.org>,
	alsa-devel@...a-project.org, devicetree@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power
 amplifiers

On Mon, May 04, 2015 at 06:51:32AM -0700, Kevin Cernekee wrote:
> On Mon, May 4, 2015 at 4:45 AM, Mark Brown <broonie@...nel.org> wrote:
> > On Sun, May 03, 2015 at 05:00:18PM -0700, Kevin Cernekee wrote:
> >> +     if (dev->of_node) {
> >> +             const struct of_device_id *of_id;
> >> +
> >> +             of_id = of_match_device(tas571x_of_match, dev);
> >> +             if (of_id)
> >> +                     priv->chip = of_id->data;
> >> +     }

> > Doesn't of_match_device() do the right thing with devices not registered
> > from DT?

> Not sure.  What kinds of situations are you concerned about?

I'm wondering why we need to bother checking for dev->of_node before
calling it.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)