linux-kernel - Re: [PATCH 47/79] namei: move link/cookie pairs into nameidata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150506072215.GW889@ZenIV.linux.org.uk>
Date:	Wed, 6 May 2015 08:22:15 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	NeilBrown <neilb@...e.de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 47/79] namei: move link/cookie pairs into nameidata

On Wed, May 06, 2015 at 12:42:54PM +1000, NeilBrown wrote:
> >  static int link_path_walk(const char *name, struct nameidata *nd)
> >  {
> > -	struct saved {
> > -		struct path link;
> > -		void *cookie;
> > -		const char *name;
> > -	} stack[MAX_NESTED_LINKS], *last = stack + nd->depth - 1;
> > +	struct saved *last = nd->stack;
> 
> This looks wrong.  'last'  used to be dependent on nd->depth, now it isn't.

On the entry to link_path_walk() we have nd->depth == 0.

And nd->depth and last are changed in sync.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/