linux-kernel - Re: [PATCH 51/79] namei: remove restrictions on nesting depth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150506125528.0be6d30e@notabene.brown>
Date:	Wed, 6 May 2015 12:55:28 +1000
From:	NeilBrown <neilb@...e.de>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 51/79] namei: remove restrictions on nesting depth

On Tue,  5 May 2015 06:22:25 +0100 Al Viro <viro@...IV.linux.org.uk> wrote:

> From: Al Viro <viro@...iv.linux.org.uk>
> 
> The only restriction is that on the total amount of symlinks
> crossed; how they are nested does not matter
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---


> -	if (unlikely(current->total_link_count >= 40)) {
> +	if (unlikely(current->total_link_count >= MAXSYMLINKS)) {

There is still a literal '40' in follow_automount.

        current->total_link_count++;
        if (current->total_link_count >= 40)
                return -ELOOP;


should that become MAXSYMLINKS too?

Thanks,
NeilBrown

Content of type "application/pgp-signature" skipped