linux-kernel - Re: [PATCH] x86: skip delays during SMP initialization similar to Xen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150506082759.GA30019@gmail.com>
Date:	Wed, 6 May 2015 10:27:59 +0200
From:	Ingo Molnar <mingo2.kernel.org@...il.com>
To:	Jan H. Schönherr <jschoenh@...zon.de>
Cc:	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Anthony Liguori <aliguori@...zon.com>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Tim Deegan <tim@....org>,
	Gang Wei <gang.wei@...el.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Len Brown <lenb@...nel.org>
Subject: Re: [PATCH] x86: skip delays during SMP initialization similar to Xen


* Jan H. Schönherr <jschoenh@...zon.de> wrote:

> Remove the per-CPU delays during SMP initialization, which seems to be
> possible on newer architectures with an x2APIC.
> 
> Xen does this since 2011. In fact, this commit is basically a
> combination of the following Xen commits. The first removes the delays,
> the second fixes an issue with the removal:
> 
> commit 68fce206f6dba9981e8322269db49692c95ce250
> Author: Tim Deegan <Tim.Deegan@...rix.com>
> Date:   Tue Jul 19 14:13:01 2011 +0100
> 
>     x86: Remove timeouts from INIT-SIPI-SIPI sequence when using x2apic.
> 
>     Some of the timeouts are pointless since they're waiting for the ICR
>     to ack the IPI delivery and that doesn't happen on x2apic.
>     The others should be benign (and are suggested in the SDM) but
>     removing them makes AP bringup much more reliable on some test boxes.
> 
>     Signed-off-by: Tim Deegan <Tim.Deegan@...rix.com>
> 
> commit f12ee533150761df5a7099c83f2a5fa6c07d1187
> Author: Gang Wei <gang.wei@...el.com>
> Date:   Thu Dec 29 10:07:54 2011 +0000
> 
>     X86: Add a delay between INIT & SIPIs for tboot AP bring-up in X2APIC case
> 
>     Without this delay, Xen could not bring APs up while working with
>     TXT/tboot, because tboot needs some time in APs to handle INIT before
>     becoming ready for receiving SIPIs (this delay was removed as part of
>     c/s 23724 by Tim Deegan).
> 
>     Signed-off-by: Gang Wei <gang.wei@...el.com>
>     Acked-by: Keir Fraser <keir@....org>
>     Acked-by: Tim Deegan <tim@....org>
>     Committed-by: Tim Deegan <tim@....org>
> 
> Signed-off-by: Jan H. Schönherr <jschoenh@...zon.de>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: Tim Deegan <tim@....org>
> Cc: Gang Wei <gang.wei@...el.com>
> ---
>  arch/x86/kernel/smpboot.c | 61 +++++++++++++++++++++++++++++------------------
>  1 file changed, 38 insertions(+), 23 deletions(-)
> 
>  This patch is against Linux 4.1-rc1.

So I really like this, as it nicely side-steps the 'when should we do 
the legacy delays' issue by flagging on x2apic support.

If anyone has objections, please holler.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/