linux-kernel - Re: [PATCH 2/2] x86/quark: Add Quark embedded SRAM self-test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150506100211.GB16458@gmail.com>
Date:	Wed, 6 May 2015 12:02:11 +0200
From:	Ingo Molnar <mingo2.kernel.org@...il.com>
To:	Bryan O'Donoghue <pure.logic@...us-software.ie>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, dvhart@...radead.org, andy.schevchenko@...il.com,
	boon.leong.ong@...el.com, linux-kernel@...r.kernel.org,
	platform-driver-x86@...r.kernel.org, derek.browne@...el.com,
	josef.ahmad@...el.com, erik.nyquist@...el.com
Subject: Re: [PATCH 2/2] x86/quark: Add Quark embedded SRAM self-test


* Bryan O'Donoghue <pure.logic@...us-software.ie> wrote:

> +/**
> + * esram_self_test_time
> + *
> + * This function is carefully constructed to measure and verify the
> + * performance boost provided by eSRAM. We invalidate the cache with a
> + * wbinvd() and then perform a series of reads - each of which will cause a
> + * cacheline miss. We measure the aggregate time it takes to complete the
> + * series of reads and return the delta in cycles. The calling function will
> + * pass either a pointer to DRAM or a pointer to eSRAM.
> + *
> + * @param walker:	Pointer to RAM area to test.
> + * @return:		Number of cycles to complete test.
> + */
> +static cycles_t esram_self_test_time(char *walker, ssize_t step, ssize_t size)
> +{
> +	volatile u32 dummy = 0;
> +	int i;
> +	int j;
> +	cycle_t t1;
> +	cycle_t t2;
> +	u32 page_count = size / PAGE_SIZE;
> +
> +	local_irq_disable();
> +	t1 = get_cycles();
> +	for (i = 0; i < page_count; i++) {
> +		for (j = 0; j < PAGE_SIZE/step; j++) {
> +			dummy += *(u32 *)walker;
> +			walker += step;
> +		}
> +	}
> +	t2 = get_cycles();
> +	local_irq_enable();
> +
> +	return t2 > t1 ? t2 - t1 : ULLONG_MAX - t2 + t1;
> +}

So I don't see the wbinvd() that the description mentions.

> + * esram_self_test_init - entry point for IMR driver.
> + * esram_self_test_exit - exit point for IMR code.

Stale 'IMR' references left over from copy & paste?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/